Skip to content

Use slider instead of text editor for ring quality#650

Closed
nessgor wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
nessgor:implement-quality-slider-for-rings
Closed

Use slider instead of text editor for ring quality#650
nessgor wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
nessgor:implement-quality-slider-for-rings

Conversation

@nessgor

@nessgor nessgor commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

Fixes #613.

Description of the problem being solved:

  • Use a slider instead of a text editor for the quality of the ring/amulet (catalyst).
  • Breach Ring: 0% - 50%
  • Other rings and amulets: 0% - 20%

Steps taken to verify a working solution:

  • Tested on POB2
  • Automatic tests successful
image

Link to a build that showcases this PR:

https://pobb.in/_f7MFDiaTEBu

Before screenshot:

image image image

After screenshot:

image image image

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jan 30, 2025
@Wires77 Wires77 added user-interface Changes that only affect the UI and removed enhancement New feature, calculation, or mod labels Feb 4, 2025
@LocalIdentity

Copy link
Copy Markdown
Contributor

I prefer the number over the slider as it's easier to see at a glance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user-interface Changes that only affect the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quality slider for rings

4 participants